Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wheel name #956

Merged
merged 13 commits into from
Oct 19, 2024
Merged

Conversation

christian-rauch
Copy link
Collaborator

@christian-rauch christian-rauch commented Oct 16, 2024

Previously, an invalid wheel file is created when setuptools is not available. This can be difficult for users to debug.

Fix this by adding an explicit check for the setuptools module and fail when it is not available. Additionally, provide some information about the module search paths for debugging.

@christian-rauch christian-rauch force-pushed the fix_wheel_name branch 2 times, most recently from 845ac02 to c96ce70 Compare October 17, 2024 20:33
@christian-rauch christian-rauch force-pushed the fix_wheel_name branch 2 times, most recently from fc5909f to f1c5d01 Compare October 17, 2024 21:05
@christian-rauch christian-rauch force-pushed the fix_wheel_name branch 4 times, most recently from dcad06c to 01a7168 Compare October 19, 2024 08:22
@christian-rauch christian-rauch force-pushed the fix_wheel_name branch 5 times, most recently from f3dc520 to 1dc9f23 Compare October 19, 2024 12:55
@christian-rauch christian-rauch marked this pull request as ready for review October 19, 2024 21:53
@christian-rauch christian-rauch merged commit 74be188 into stevenlovegrove:master Oct 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants